Browse Source

Added safety checks

Théo Ertzscheid 2 years ago
parent
commit
a1441c3543
3 changed files with 33 additions and 4 deletions
  1. 18 3
      addtogroups
  2. 6 0
      createperson
  3. 9 1
      person2posix

+ 18 - 3
addtogroups

@@ -1,7 +1,17 @@
 #!/bin/bash
 . .env
+. funcs
+
 uid=$1
 
+if user_exists $uid; then
+    true
+else
+    echo "User $uid does not exist." 
+    exit 1
+fi
+
+
 group="dn: cn=%GROUP%,$GROUPSDN
 changeType: modify
 add: member
@@ -13,7 +23,12 @@ shift
 
 # add user to each of the groups given
 for g in $@; do
-    echo "$group" | sed \
-	-e "s/%GROUP%/$g/" \
-	-e "s/%UID%/$uid/" #| $MODIFY_CMD
+    echo $g
+    if group_exists $g ; then
+        echo "$group" | sed \
+            -e "s/%GROUP%/$g/" \
+            -e "s/%UID%/$uid/" #| $MODIFY_CMD
+    else
+        echo "Group $g does not exist, skipping..."
+    fi
 done

+ 6 - 0
createperson

@@ -1,11 +1,17 @@
 #!/bin/bash
 . .env
+. funcs
 
 read -p "UID: " uid
 read -p "GivenName: " gn
 read -p "Name: " sn
 pw=$(sudo slappasswd -s salut$uid)
 
+if user_exists $uid; then
+    echo "User $uid already exist." 
+    exit 1
+fi
+
 user="dn: uid=$uid,$PEOPLEDN
 objectClass: top
 objectClass: inetOrgPerson

+ 9 - 1
person2posix

@@ -1,6 +1,14 @@
 #!/bin/bash
 . .env
-uid=${1}
+. funcs
+uid=$1
+
+if user_exists $uid; then
+    true
+else
+    echo "User $uid does not exist." 
+    exit 1
+fi
 
 user="dn: uid=%UID%,$PEOPLEDN
 changeType: modify